Personal tools
  • We're Hiring!

You are here: Home Community Minutes Mini Group meetings Web client meetings 2012 2012-05-07

2012-05-07

Attending: Chris, Emma, Ola, Will, Scott, Gus, Carlos

Agenda

List of active branches.

List of active Pull Requests.

To discuss:

  1. #8685 reopen and rewrite tests.

    • ACTION Ola is going to adjust utest. DONE
    • ACTION Josh is going to adjust security context implementation based on the new utests.
    • Ola: It looks like SecurityViolation is raised because omero.gateway.ImageWrapper._prepareTB sets 'SERVICE_OPTS' based on the image details (group id of the image owner) rather then group id from the event context (group id of the member of the share accessing image. In that case security system does not know what to do. Either we define the hierarchy of parameters or we change the implementation. Please refer to the #8687 because more issues like that appeared in the log.
    • Josh: The intent is certainly not that "omero.group" and "omero.share" be set at the same time. It would probably be good to specify what that even means. What I was expecting clients to do was to set omero.share if the share is active, and otherwise use whatever omero.group the implementation needs (like that from the group, etc). In other words, for a share invocation, omero.share should suffice, and if you want to try to set omero.group too we can make that work but you should definitely not use just the group for an object in the share, since that doesn't tell the server to switch to the "share" implementation. We can certainly just make the decision that if omero.share is set at all, that the other values will be ignored. That's easy enough. I just want to make sure before I do that, that it coincides what you guys are expecting. Perhaps you can discuss and let me know. I should be able to fix that tomorrow then.
  2. (5 min) UI changes in 4.4.

    • #8623 "List of Interface Priorities"
  3. (5 min) #8234 Web: groups & user. NOT 4.4.0 webclient!

    • AWAITING #8567 Additional changes to the gateway
  4. (5 min) #8434 CHMOD

    • chmod_web branch (will) has server chmod changes WITH 8610_ branch merged in. Awaiting perms.canLink(), canDelete()
    • Ola: #8438 changePermission in Webadmin
    • Will: #8708 perms in jsTree. E.g. class="canEdit canLink"
    • Will: #8709 Toolbar, right-click menu etc enabled from tree node classes
  5. (5 min) #8544 4.4 TODOs Requirement.

    • AWAITING Landing page
  6. (5 min) #8596 ticket closing session.

    • ACTION Chris: I need to do close in gateway option directly.
  7. (5 min) Model changes

  8. #8508 Logical channel changes in Web/Python

  9. #8084 ROI changes in Web/Python

  10. (5 min) Others:

    • Ola: #7383 prepare_session review @login_required
    • #7202 Unittests review. some changes in 7202_unittest_review
    • #8508 Logical Channel model changes
    • testing plans in general
    • Jason: "Let me know how likely we are to have web done before Paris"
      • 1st June is less than 4 weeks away. Will is away on 9th June, Paris on 18th.
      • Most of UI is looking good. Only 'small' bugs etc.
      • How long for Permissions, Model changes, Cleanup, Docs??

Notes

  1. #8685 reopen and rewrite tests.

    • Ola: It looks like SecurityViolation is raised because omero.gateway.ImageWrapper._prepareTB sets 'SERVICE_OPTS' based on the image details (group id of the image owner) rather then group id from the event context (group id of the member of the share accessing image. In that case security system does not know what to do. Either we define the hierarchy of parameters or we change the implementation. Please refer to the #8687 because more issues like that appeared in the log.
    • Josh: The intent is certainly not that "omero.group" and "omero.share" be set at the same time. It would probably be good to specify what that even means. What I was expecting clients to do was to set omero.share if the share is active, and otherwise use whatever omero.group the implementation needs (like that from the group, etc). In other words, for a share invocation, omero.share should suffice, and if you want to try to set omero.group too we can make that work but you should definitely not use just the group for an object in the share, since that doesn't tell the server to switch to the "share" implementation. We can certainly just make the decision that if omero.share is set at all, that the other values will be ignored. That's easy enough. I just want to make sure before I do that, that it coincides what you guys are expecting. Perhaps you can discuss and let me know. I should be able to fix that tomorrow then.
    • Similar issue appeared in #8687
  2. (5 min) UI changes in 4.4.

    • Dom: Functionality wise there are few bugs, table not showing etc. maybe css issue. It doesn;t look as great but looks similar.
    • Scott: icon for activity, bell vs arrows represent process. Arrows decided.
    • Will: Icon for various group permissions. More colours.
    • Dom: there might be some small bugs pops up after I am gone. .
  3. (5 min) #8544 4.4 TODOs Requirement.

    • Jason: "Let me know how likely we are to have web done before Paris"

      • 1st June is less than 4 weeks away. Will is away on 9th June, Paris on 18th.
      • Most of UI is looking good. Only 'small' bugs etc.
      • How long for Permissions, Model changes, Cleanup, Docs??
    • 5 weeks remaining!

    • Ola and Will went through the Permissions and Model changes needed still on Python/Web site. Model changes mostly cover renaming. It shouldn't take more then few days to update gateway and views. Permissions is something that is still not working as expected and this require more work from Josh. Webclient side changes were defined in #8708 and #8709

    • We make constant cleanup and review.

    • Docs are spread across various tickets, we do not have developer examples but we could add them afterwards to the examples as this is not a part of the release. There are no movies as we were doing them as post release task in the past.

      • Emma: we will need movies covering new features before.
Document Actions