Personal tools
  • We're Hiring!

You are here: Home Community Minutes Mini Group meetings OME-XML Meetings 2012.02.17 - Model & Database Alignment

2012.02.17 - Model & Database Alignment

Report of the discussion to resolve ROI and other DB discrepancies that took place at the developers meeting.

Notes by AndrewP

This is a summary of the changes decided. I have split them as DB changes and Model changes, thought the discussion went back and forward (and round and round). We were working through the trac page OmeModel/DatabaseComparison.

In DB:

  • Add "markerstart" to "shape" table
  • Add "markerend" to "shape" table
  • Add "name" to "roi" table
  • Rename "positionX" in "stagelabel" table to "x"
  • Rename "positionY" in "stagelabel" table to "y"
  • Rename "positionZ" in "stagelabel" table to "z"
  • Rename "posX" in "wellsample" table to "x"
  • Rename "posY" in "wellsample" table to "y"
  • Rename "textvalue" in "shape" table to "text"
  • Rename "rx" in "shape" table to "radiusx"
  • Rename "ry" in "shape" table to "radiusy"
  • Delete "cx" in "shape" (now use "x")
  • Delete "cy" in "shape" (now use "y")
  • Delete "g" in "shape" table
  • Delete "fontStretch" in "shape" table
  • Delete "strokeDashOffset" in "shape" table
  • Delete "strokeLineCap" in "shape" table
  • Delete "strokeLineJoin" in "shape" table
  • Delete "strokeMiterLimit" in "shape" table
  • Delete "vectorEffect" in "shape" table
  • Delete "keywords" in "roi" table
  • Delete "pixels" in "roi" table
  • Change "namespaces" in "roi" table, which is currently a list of namespaces to be a single namespace called "namespace"

In Model:

  • Move "MarkerStart" & "MarkerEnd" down into "Line", "Polyline"
  • Add "Polygon" element (a new type of Shape)
  • Delete "Closed" from Polyline (transform a Closed Polyline into a Polygon)
  • Rename "AcquiredDate" to "AcquisitionDate" in "Image"
  • Ensure all colours are stored as new type "Color"
  • Delete "Name" from "Shape"
  • Delete "Description" from "Shape"
  • Delete "Value" from "Text"
  • Rename "Text" element to "Label"
  • Rename "Label" attribute in "Shape" to "Text" (type [plane text string], i.e. single line)
  • Add "Visibility" to "Shape"
  • Rename "Fill" attribute in "Shape" to "FillColor"
  • Rename "Stroke" attribute in "Shape" to "StrokeColor"

General:

  1. Search entire codebase for colour
    • There are over 2,000 places in the codebase where colour is spelled correctly as either "Colour", "colour" or "COLOUR"
    • There are over 43,000 places in the codebase where colour is spelled incorrectly as either "Color", "color" or "COLOR"
    • About 250 lines of code use both spellings.
  2. RGBA, add helpers were we can.

Outstanding or unclear in my notes

  1. Check these / see ticket #

    • Shape:? fontVariant (Remove from DB)
    • Shape:? fontWeight (Result - merge with fontStyle and remove from DB)
  2. Check this!

    • Shape:? locked
Document Actions